bpo-18795: Add cumpercall and totalpercall keys to pstats sort_stats#31919
Open
DanielNoord wants to merge 1 commit into
Open
bpo-18795: Add cumpercall and totalpercall keys to pstats sort_stats#31919DanielNoord wants to merge 1 commit into
DanielNoord wants to merge 1 commit into
Conversation
MaxwellDupre
approved these changes
Apr 29, 2022
MaxwellDupre
left a comment
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Ran 9 tests in 0.450s
OK
Looks ok.
|
All commit authors signed the Contributor License Agreement. |
DanielNoord
force-pushed
the
fix-issue-18795
branch
2 times, most recently
from
b672f5c to
dfdabbf
Compare
Co-authored-by: Alexandre Dias
DanielNoord
force-pushed
the
fix-issue-18795
branch
from
dfdabbf to
c84bc36
Compare
Contributor
Author
|
Hey @pablogsal. Had to rebase this on #142373, which I thought was best as a force push as it changed so much of the original patch. Considering PEP 799 you should probably on the "nosy list" of this module now, but you were never tagged on the original issue. |
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
Author
|
I don't know how to not make this stale. Nobody seems to be available to review it. |
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly a resubmit of the patch already found at bpo-18795.
I also updated the documentation.
I tried to give credit to the main/co-author, but couldn't find their email address so was only able to include their full name.
Let me know if anything needs to be changed here 😄
https://bugs.python.org/issue18795
Closes #62995